Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment]Allow member lookup from call when members in request are empty #660

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

https://getstream.slack.com/archives/C07UG155ERE/p1738777320325749?thread_ts=1738678288.567589&cid=C07UG155ERE

📝 Summary

When a call is being created from another device than the one actually starting it, we need a way to provide nil value for members. When we do, the client doesn't have to provide the members of the call and instead the value will be filled from the backend. This comes closer to the implementation that React and Android have.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Feb 7, 2025
@ipavlidakis ipavlidakis self-assigned this Feb 7, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner February 7, 2025 11:36
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Feb 7, 2025

SDK Size

title develop branch diff status
StreamVideo 7.46 MB 7.46 MB 0 KB 🟢
StreamVideoSwiftUI 2.07 MB 2.07 MB 0 KB 🟢
StreamVideoUIKit 2.21 MB 2.21 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@ipavlidakis ipavlidakis enabled auto-merge (squash) February 7, 2025 11:55
@ipavlidakis ipavlidakis changed the title Fix/member request null [Alignment]Allow member lookup from call when members in request are empty Feb 7, 2025
@ipavlidakis ipavlidakis enabled auto-merge (squash) February 7, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants