Merge pull request #88 from unlimmitted/master

Fix NullPointerException
GideonLeGrange · Sep 26, 2024 · ed0468d · ed0468d
2 parents 75a140f + bfbe507
commit ed0468d
Showing 1 changed file with 16 additions and 12 deletions.
diff --git a/src/main/java/me/legrange/mikrotik/impl/ApiConnectionImpl.java b/src/main/java/me/legrange/mikrotik/impl/ApiConnectionImpl.java
@@ -255,20 +255,24 @@ public void run() {
                 } catch (MikrotikApiException ex) {
                     continue;
                 }
-                ResultListener l = listeners.get(res.getTag());
-                if (l != null) {
-                    if (res instanceof Result) {
-                        l.receive((Result) res);
-                    } else if (res instanceof Done) {
-                        if (l instanceof SyncListener) {
-                            ((SyncListener) l).completed((Done) res);
-                        } else {
-                            l.completed();
+                if (res.getTag() != null) {
+                    ResultListener l = listeners.get(res.getTag());
+                    if (l != null) {
+                        if (res instanceof Result) {
+                            l.receive((Result) res);
+                        } else if (res instanceof Done) {
+                            if (l instanceof SyncListener) {
+                                ((SyncListener) l).completed((Done) res);
+                            } else {
+                                l.completed();
+                            }
+                            listeners.remove(res.getTag());
+                        } else if (res instanceof Error) {
+                            l.error(new ApiCommandException((Error) res));
                         }
-                        listeners.remove(res.getTag());
-                    } else if (res instanceof Error) {
-                        l.error(new ApiCommandException((Error) res));
                     }
+                } else {
+                    nextTag();
                 }
             }
         }