Prevent /Temp filling up with temporary files #451
Conversation
Gee-64
force-pushed
the
feature/temp-files-house-keeping
branch
from
3227ad1 to
9e233b5
Compare
Limits number of temporary files from the HTTP API as well as from the Assembly64 integration. House keeping retains at least 2 files, but may go up to 16 files or 1MB of total size, whichever is reached first. Older files are deleted before newer. The limits are counted separately for API files and Assemby64 files. Temporary filenames were changed to have a slightly nicer (?) names and start numbering at 1 instead of 0 since this is (arguably) more intuitive to the user. Also fixes a tiny typo in a comment.
Gee-64
force-pushed
the
feature/temp-files-house-keeping
branch
from
9e233b5 to
0e09c79
Compare
|
Rebased on top of u64ii to once again test the build caching. @GideonZ |
|
Ah, but maybe you are right that it won't work though - the u64ii branch had a build when you merged master back into it... And the cache should have been seeded then. |
|
@Gee-64 I checked the caches. Same hash. I don't understand! Grrrrr.... You could check my build.yml if you like. |
|
@GideonZ Dang. I'll try and read up on GitHub Actions and have a look. |
|
@GideonZ Everything looks fine to me in build.yml. Even when taking into consideration the quite restrictive cache lookup rules enforced by GitHub, a PR branch should be able to restore files from the PRs "base branch" (i am assuming this would be u64ii in our case). The only thing I can think of to try would be to check if caching starts working when u64ii is merged into master (since the cache for the "default" branch should be available to all other branches). Alternatively temporarily making the u64ii branch the default branch. |
|
Moving future discussion of build cache back to #465. |
|
Wups, accidentally deleted this branch while cleaning out stale branches. This PR was closed so will re-open a new one. |
Limits number of temporary files from the HTTP API as well as from the Assembly64 integration. House keeping retains at least 2 files, but may go up to 16 files or 1MB of total size, whichever is reached first. Older files are deleted before newer. The limits are counted separately for API files and Assemby64 files.
Temporary filenames were changed to have a slightly nicer (?) names and start numbering at 1 instead of 0 since this is (arguably) more intuitive to the user.
Also fixes a tiny typo in a comment.
This solves #435.