forked from angular/angular
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kupret.inc 2 #54
Open
usernamealreadyis
wants to merge
3,019
commits into
GistIcon:perftest
Choose a base branch
from
xccvv:kupret.inc-2
base: perftest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kupret.inc 2 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a zone counting timeouts and microtasks to determine when a test is finished, instead of requiring the test writer to use injectAsync and return a promise. See angular#5322
BREAKING CHANGE: Previously, components that would implement lifecycle interfaces would include methods like "onChanges" or "afterViewInit." Given that components were at risk of using such names without realizing that Angular would call the methods at different points of the component lifecycle. This change adds an "ng" prefix to all lifecycle hook methods, far reducing the risk of an accidental name collision. To fix, just rename these methods: * onInit * onDestroy * doCheck * onChanges * afterContentInit * afterContentChecked * afterViewInit * afterViewChecked * _Router Hooks_ * onActivate * onReuse * onDeactivate * canReuse * canDeactivate To: * ngOnInit, * ngOnDestroy, * ngDoCheck, * ngOnChanges, * ngAfterContentInit, * ngAfterContentChecked, * ngAfterViewInit, * ngAfterViewChecked * _Router Hooks_ * routerOnActivate * routerOnReuse * routerOnDeactivate * routerCanReuse * routerCanDeactivate The names of lifecycle interfaces and enums have not changed, though interfaces have been updated to reflect the new method names. Closes angular#5036
BREAKING CHANGE: Previously, pipes that wanted to be notified when they were destroyed would implement the PipeOnDestroy interface and name the callback `onDestroy`. This change removes the PipeOnDestroy interface and instead uses Angular's lifecycle interface `OnDestroy`, with the `ngOnDestroy` method. Before: ``` import {Pipe, PipeOnDestroy} from 'angular2/angular2'; @pipe({pure: false}) export class MyPipe implements PipeOnDestroy { onDestroy() {} } ``` After: import {Pipe, OnDestroy} from 'angular2/angular2'; @pipe({pure: false}) export class MyPipe implements PipeOnDestroy { ngOnDestroy() {} }
Remove deprecated `reflectPropertiesAsAttributes` as an option. It has been renamed `reflect_properties_as_attributes`. Closes angular#5108 Closes angular#5512
…en building benchpress
Detect the `@AngularEntrypoint` annotations on methods and/or functions and add a call to `initReflector` there. See angular#4865
Add an implementation of the transformer which runs only the phases which replace `Asset`s, rather than generate them. Closes angular#5484
These have been deprecated for a while. Instead of angular2/test, use angular2/testing. Instead of angular2/test_lib, use angular2_testing_internal.
I think people new to promises, angular etc will find this example easier to understand with concrete identifiers from a simple use-case. The existing naming could be confused with promise/angular functionality (`promise` in the template, `resolved` etc). Also I made `resolve` private, as then it's clear what we're exposing for the template.
… n from 'angular2''' The typings property is being removed because angular2.ts is deprecated, and the developers should import from angular2/core and angular2/platform/*. So aliasing angular2 to angular2/angular2 does not make sense. BREAKING CHANGE Before import * as ng from 'angular2'; After import * as core from 'angular2/core';
- we now correctly print errors even on old Node versions - we print error messages even when node_modules are missing or messed up - error messages looks better Closes angular#5230
Couple of typos fixed: - occuring -> occurring - imlement -> implement - idenitifer -> identifer etc... Closes angular#5943
This commit reverts a8d9dbf that introduced a code size regression (16kb gzipped, 63kb minified) in Dart. Effect on the hello world app: gzipped: 105kb -> 89kb minified: 370kb -> 317kb BREAKING CHANGE: - This is very unlikely to be breaking, but I'm still marking just in case. The only change to the user should be that dev mode is driven by Dart's checked mode, like it was in the past.
Our code size SLA is 100kb gzipped and 300kb minified. Our target is 10kb gzipped. We are currently under 90kb gzipped. Let's keep it that way while looking for ways to improve the situation further. We're not <300kb minified yet, so we should be stricter here too. Closes angular#5896
Before, all test framework wrappers (internal for dart and js/ts, angular2_test for dart and testing for js/ts) had similar logic to keep track of current global test injector and test provider list. This change wraps that logic into one class managed by the test injector. Closes angular#5920
param:injector ; hide:param ; close:propose :+1
Update README.md update::+1
This changes the way we calculate specificity. Instead of using a number, we use a string, so that combining specificity across parent-child instructions becomes a matter of concatenating them Fixes angular#5848 Closes angular#6011
use caretaker rather than "on-duty" Closes angular#6058
fixes angular#6075 Closes angular#6078
clone.git
This form allows you to encrypt sensitive data before saving it into appveyor.yml file. Secure strings are currently supported in environment, deploy and notifications sections.
travis.yml
supported in environment, deploy and notifications sections.# configuration for "master" branch # build in Release mode and deploy to Azure - branches: only: - master configuration: Release deploy: provider: AzureCS ... # configuration for all branches starting from "dev-" # build in Debug mode and deploy locally for testing - branches: only: - /dev-.*/ configuration: Debug deploy: provider: Local ... # "fall back" configuration for all other branches # no "branches" section defined # do not deploy at all - configuration: Debug
[[PrimitiveValue]] ***Internal state information associated with this object. Of the standard built-in ECMAScript objects, only Boolean, Date, Number, and String objects implement [[PrimitiveValue]].*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: @GistIcon/bola