Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: change catalan locale & route to ct from ca #4988

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

divine-comedian
Copy link
Contributor

user report from not being able to access giveth by default in english when connecting from Canada

changed routing and locale notation of catalan from ca to ct to not get confused with canada locale of ca-en or ca-fr

this will allow user to share giveth page in english for QF round with their communities in Canada and it will show up in readable language.

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 10:18pm

Copy link
Collaborator

@kkatusic kkatusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, lgtm, thx @divine-comedian .

I also checked is "ct" code free, not attached to any languages and its ok ;)
https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes

@divine-comedian divine-comedian merged commit 36da5ea into main Jan 30, 2025
4 checks passed
@divine-comedian divine-comedian deleted the stop-canada-in-catalan branch January 30, 2025 15:38
@divine-comedian
Copy link
Contributor Author

related to: #4993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants