Hotfix add matching funds as donations #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just added a button in admin panel to sync donations with distributed matching funds, but we should add some cronjobs for that to call the function daily, or something like that Relate Donations with Distributed Funds button |
jainkrati
reviewed
Dec 5, 2023
| "matchingFundPriceUsd" = 1, | ||
| "matchingFundCurrency" = 'WXDAI' | ||
| WHERE | ||
| id = 2 AND "matchingFund" IS NOT NULL; |
There was a problem hiding this comment.
why are we hard coding the id to 2?
There was a problem hiding this comment.
We have some qf rounds already in our DB and they have qfRoundHistory items in DB, they dont have new fields, so I had to put their ids hard coded here
There was a problem hiding this comment.
jainkrati
reviewed
Dec 5, 2023
src/services/donationService.ts
Outdated
|
|
||
| const matchingFundFromAddress = | ||
| (process.env.MATCHING_FUND_DONATIONS_FROM_ADDRESS as string) || | ||
| '0x6e8873085530406995170Da467010565968C7C62'; // Address behind donation.eth ENS address; |
There was a problem hiding this comment.
lets take this as a constant value
jainkrati
requested changes
Dec 5, 2023
jainkrati
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1186