Reuse donation resolver #1257
Merged
Reuse donation resolver #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohammadranjbarz @CarlosQ96 I haven't tested it, do you think it would work? |
mohammadranjbarz
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Thanks @aminlatifi now it's much cleaner and better.
I added a test case and fixed the function
Thanks @mohammadranjbarz @CarlosQ96 Please review this and if it is approved, feel free to merge this and #1253 |
|
@CarlosQ96 I had to merge this, since further update fo #1253 would cause conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored createBackupDonation to reuse resolver