Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-verify-donation-job-queue-add #1258

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix-verify-donation-job-queue-add #1258

merged 2 commits into from
Jan 23, 2024

Conversation

aminlatifi
Copy link
Member

@aminlatifi aminlatifi changed the base branch from staging to master January 22, 2024 14:10
@aminlatifi aminlatifi changed the base branch from master to staging January 22, 2024 14:13
CarlosQ96
CarlosQ96 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, ok. I merged master to staging to its weird it still showing it as changes instead of just your PR commit. Can merge.

mohammadranjbarz
mohammadranjbarz approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aminlatifi Code seems good, but I don't know how it solves the problem

@aminlatifi
Copy link
Member Author

@aminlatifi Code seems good, but I don't know how it solves the problem

When an issue happens in verification, the donation is added multiple times!
So, the verify process is called plenty of times in this case

@aminlatifi aminlatifi merged commit a00ed03 into staging Jan 23, 2024
3 checks passed
@aminlatifi aminlatifi deleted the fix-verify-donation-job-queue-add branch January 23, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

@mohammadranjbarz mohammadranjbarz mohammadranjbarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aminlatifi @mohammadranjbarz @CarlosQ96