Add importDate to donation entity #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminlatifi
requested changes
Jan 23, 2024
| @@ -110,7 +110,7 @@ export const createBackupDonation = async ( | |||
| safeTransactionId, | |||
| ); | |||
| const donation = (await findDonationById(Number(donationId))) as Donation; | |||
| donation!.createdAt = getCreatedAtFromMongoObjectId(donationData._id); | |||
| donation!.importDate = getCreatedAtFromMongoObjectId(donationData._id); | |||
There was a problem hiding this comment.
Keep it as it is, just add a line after and set the importDate to now.
| @@ -49,7 +49,7 @@ function createBackupDonationTestCases() { | |||
| assert.equal(donation.status, DONATION_STATUS.PENDING); | |||
|
|
|||
| // should use input createdAt not now time | |||
| assert.equal(donation.createdAt.getTime(), 1705577862000); | |||
| assert.equal(donation.importDate.getTime(), 1705577862000); | |||
There was a problem hiding this comment.
Also, don't change this as well.
| export class addImportDateToDonationEntity1706012712969 implements MigrationInterface { | ||
|
|
||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(`ALTER TABLE "donation" ADD COLUMN "importDate" TIMESTAMP WITH TIME ZONE`); |
There was a problem hiding this comment.
Suggested change
| await queryRunner.query(`ALTER TABLE "donation" ADD COLUMN "importDate" TIMESTAMP WITH TIME ZONE`); | |
| await queryRunner.query(`ALTER TABLE "donation" ADD COLUMN IF NOT EXISTS "importDate" TIMESTAMP WITH TIME ZONE`); |
aminlatifi
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.