Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for triggering haptic pulses in the wand #56

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Add support for triggering haptic pulses in the wand #56

merged 1 commit into from
Nov 26, 2023

Conversation

patrickdown
Copy link
Collaborator

Added trigger_haptic_pulse function to T5Controller3D

@patrickdown patrickdown self-assigned this Nov 23, 2023
Malcolmnixon
Malcolmnixon approved these changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and works well. I do agree that 'int' is a better type here as the code is starting to deal with 'index' and adding support for invalid indexes.

@patrickdown
Add support for triggering haptic pulses in the wand
dc0a6f5 
Added trigger_haptic_pulse function to T5Controller3D
@patrickdown patrickdown merged commit c4c71fb into GodotVR:main Nov 26, 2023
2 checks passed
@patrickdown patrickdown deleted the add_haptic_pulse branch December 6, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malcolmnixon Malcolmnixon Malcolmnixon approved these changes

Assignees

@patrickdown patrickdown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickdown @Malcolmnixon