Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gdscript plugin XRRig to be in line with csharp changes #58

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Update gdscript plugin XRRig to be in line with csharp changes #58

merged 1 commit into from
Nov 26, 2023

Conversation

patrickdown
Copy link
Collaborator

Added to T5XRRig:
var glasses_id : StringName
var gameboard_type := T5Def.GameboardType.Unknown
var gameboard_size := AABB()
var origin : T5Origin3D
var camera : T5Camera3D
var wand : T5Controller3D

Updated T5 interface to use these
Added T5Def to hold gameboard type and wand control names

@patrickdown
Update gdscript plugin XRRig to be in line to csharp changes
bc92410 
Added to T5XRRig:
var glasses_id : StringName
var gameboard_type := T5Def.GameboardType.Unknown
var gameboard_size := AABB()
var origin : T5Origin3D
var camera : T5Camera3D
var wand : T5Controller3D

Updated T5 interface to use these
Added T5Def to hold gameboard type and wand control names
@patrickdown patrickdown self-assigned this Nov 26, 2023
@patrickdown patrickdown changed the title Update gdscript plugin XRRig to be in line to csharp changes Update gdscript plugin XRRig to be in line with csharp changes Nov 26, 2023
@patrickdown patrickdown linked an issue Nov 26, 2023 that may be closed by this pull request
Add control mapping strings to plugin #53
Closed
Malcolmnixon
Malcolmnixon approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have been tested by merging into TiltFiveTools and work well.

@patrickdown patrickdown merged commit f6f1e2d into GodotVR:main Nov 26, 2023
2 checks passed
@patrickdown patrickdown deleted the cs_xrrig_changes_to_gd branch December 6, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malcolmnixon Malcolmnixon Malcolmnixon approved these changes

Assignees

@patrickdown patrickdown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add control mapping strings to plugin
2 participants
@patrickdown @Malcolmnixon