-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added rumble manager and demo #250
Conversation
Feel free to be brutal. I'd rather have it right. Also, I did not implement rumbling across the functions of the toolkit (didn't know whether that should be in here or later) just in the demo. |
@Malcolmnixon wants me to create a sort of "Rumble Player" to that can find the rumble manager, and provide a means to add rumble to any function/gun/etc |
After more discussion with @Malcolmnixon I will be making the rumble manager a singleton which "XRToolRumbleFeature"s added to the controllers will ensure exist. This Singleton will be easier to access from scripts that want to make rumbling happen. |
I had forgotten how primitive haptics are implemented in Godot 3 :) At first glance I think I get the idea behind this and it seems a good approach, I'll have to find some more time to actually experiment with it. This is the kind of enhancement that could use more detail in the OP to explain what is being added and how its supposed to be used from a user point of view (i.e. someone making a game). |
Quick discussion in XR meeting about this as we'd like to move forward with this PR. Need to get input from more XR tool users what they are expecting out of rumble and whether this is a solution they agree with. Would love everyones feedback. @lunarcloud would you mind rebasing this so that the merge issues are resolved so people can test? |
4472863
to
0e01180
Compare
add rumble manager and demo
0e01180
to
bbf90ba
Compare
Superceded by #557 |
Implement #191