Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rumble manager and demo #250

Closed
wants to merge 1 commit into from

Conversation

lunarcloud
Copy link
Contributor

@lunarcloud lunarcloud commented Nov 7, 2022

Implement #191

@lunarcloud
Copy link
Contributor Author

Feel free to be brutal. I'd rather have it right.

Also, I did not implement rumbling across the functions of the toolkit (didn't know whether that should be in here or later) just in the demo.

@lunarcloud
Copy link
Contributor Author

@Malcolmnixon wants me to create a sort of "Rumble Player" to that can find the rumble manager, and provide a means to add rumble to any function/gun/etc

@lunarcloud
Copy link
Contributor Author

lunarcloud commented Nov 7, 2022

After more discussion with @Malcolmnixon I will be making the rumble manager a singleton which "XRToolRumbleFeature"s added to the controllers will ensure exist. This Singleton will be easier to access from scripts that want to make rumbling happen.

@BastiaanOlij
Copy link
Member

I had forgotten how primitive haptics are implemented in Godot 3 :)

At first glance I think I get the idea behind this and it seems a good approach, I'll have to find some more time to actually experiment with it.

This is the kind of enhancement that could use more detail in the OP to explain what is being added and how its supposed to be used from a user point of view (i.e. someone making a game).

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Nov 24, 2022
@BastiaanOlij BastiaanOlij added this to the 3.2.0 milestone Nov 24, 2022
@BastiaanOlij BastiaanOlij modified the milestones: 3.2.0, 3.3.0 Jan 25, 2023
@BastiaanOlij
Copy link
Member

Quick discussion in XR meeting about this as we'd like to move forward with this PR. Need to get input from more XR tool users what they are expecting out of rumble and whether this is a solution they agree with.

Would love everyones feedback.

@lunarcloud would you mind rebasing this so that the merge issues are resolved so people can test?

add rumble manager and demo
@BastiaanOlij BastiaanOlij modified the milestones: 3.3.0, 3.4.0 Feb 24, 2023
@BastiaanOlij BastiaanOlij modified the milestones: 3.4.0, 3.5.0 Mar 4, 2023
@BastiaanOlij BastiaanOlij changed the base branch from master to 3.x March 4, 2023 11:45
@BastiaanOlij BastiaanOlij modified the milestones: 3.5.0, 3.6.0 Apr 22, 2023
@lunarcloud
Copy link
Contributor Author

Superceded by #557

@lunarcloud lunarcloud closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants