Utilities #51
Utilities #51
Conversation
The color scale is a feature of the layer system to allow some basic color manipulation like a fade to black without the need of expensive post processing.
| GDCALLINGCONV void *ovr_utilities_constructor(godot_object *p_instance, void *p_method_data); | ||
| GDCALLINGCONV void ovr_utilities_destructor(godot_object *p_instance, void *p_method_data, void *p_user_data); | ||
|
|
||
| GDCALLINGCONV godot_variant get_ipd(godot_object *p_instance, void *p_method_data, void *p_user_data, int p_num_args, godot_variant **p_args); |
There was a problem hiding this comment.
@NeoSpark314 Can you add some documentation for the new get_ipd and set_default_layer_color_scale methods.
There was a problem hiding this comment.
Yes; I added a short documentation in the header. I also added a short example in the README.md. Do you already have an idea/plan on how all this will be documented in the end for 3.2? Will the doc be part of the repo or separate. If it is part of the repo will everything be in the README.md or a new file/folder?
There was a problem hiding this comment.
The documentation will be part of the main Godot documentation (under a vr/Quest section) so as to make discovery easier for people interested in using the functionality.
The README.md will have a short TLDR for setting up the plugin, as well as descriptions of major functionalities, with a link to the full documentation for more details.
|
Looks great, thanks! |
This PR contains a proposal to add a OvrUtilities.gdns that has at the moment two functions exposed.
1.: get_ipd(): uses the left and right view matrix to compute and return the current IPD by computing the difference between the left and right eye position.. This can be used to see what IPD was set using the hardware slider on the Oculus Quest (and will also return the IPD of the other oculus mobile headsets)
2: set_default_layer_color_scale(r, g, b, a): this exposes the layer color multiplyer from the VrAPI for the default layer (that is used to display the rendered scene). The main use-case for this is to implement efficient fade to black. Using std. post processing for this is too expensive on tiled rendering architectures (see also #45). For this reason the ColorScale is exposed on each layer.
In the future the OvrUtilities.gdns can also be used to expose other funcitonality to a user like using/configuring the compositing layers.