Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E tests #2699

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Fix E2E tests #2699

merged 1 commit into from
Nov 16, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Nov 16, 2024

Make outputs of service account depend on the IAM grants given within the module, so SA has all necessary permissions when used in other contexts.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn
Copy link
Collaborator Author

wiktorn commented Nov 16, 2024

@ludoo
Copy link
Collaborator

ludoo commented Nov 16, 2024

This is one more of the "I'm not sure this won't introduce circular deps" PRs...

@wiktorn
Copy link
Collaborator Author

wiktorn commented Nov 16, 2024

I know :-)

ludoo
ludoo approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always way of adding new dependencies in the outputs of our core modules (see PR comment above), but if you're 100% sure about this, go ahead.

ludoo
ludoo requested changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, tests show cycles in both fast and blueprints. Let's maybe not merge this.

@wiktorn
Copy link
Collaborator Author

wiktorn commented Nov 16, 2024

I'm not yet sure. I'm waiting for E2E tests to go 💥 :-)

@ludoo
Copy link
Collaborator

ludoo commented Nov 16, 2024

I'm not yet sure. I'm waiting for E2E tests to go 💥 :-)

well, seeing cycles pop up in the plan tests is a red flag enough for me :)

@wiktorn wiktorn changed the title Fix E2E tests, make service account outputs depend on IAM grants Fix E2E tests Nov 16, 2024
@wiktorn wiktorn merged commit 9e6b114 into master Nov 16, 2024
18 checks passed
@wiktorn wiktorn deleted the wiktorn-fix-e2e-tests branch November 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @ludoo