Use detect-exceptions plugin to detect exceptions in unstructured log streams. #12
Conversation
There was a problem hiding this comment.
As a heads-up, we plan to move away from purely text-based default configs to more structured default configs (#10). So the usefulness of this change may be somewhat short-lived.
configs/config.d/cassandra.conf
Outdated
| @@ -5,7 +5,7 @@ | |||
| path /var/log/cassandra/system.log | |||
| pos_file /var/lib/google-fluentd/pos/cassandra-system.pos | |||
| read_from_head true | |||
| tag cassandra | |||
| tag detect_exceptions_java.cassandra | |||
There was a problem hiding this comment.
Should these be detect-exceptions-java.cassandra instead?
| max_lines 500 | ||
| </match> | ||
|
|
||
| <match detect-exceptions-go-ruby.**> |
There was a problem hiding this comment.
This seems somewhat arbitrary, and implies that we might need to add tags with multiple combinations of configs... I wonder if we could somehow extract the languages from the tag instead?..
There was a problem hiding this comment.
Transmitting the info which languages to consider via the tag is a valid idea. However, since only Gitlab is affected by this and the limitation of the languages to consider is anyway a kind of micro-optimization (the plugin runs fine in production e.g. on GAE flex with considering all languages), I decided to rather get rid of this special case for now.
|
Hi Igor, comments addressed. PTAL. |
igorpeshansky
changed the title
but I'd like 
|
Sorry, @thomasschickinger, this got lost in the ether for a while. |
|
@igorpeshansky can we resolve this PR? |
No description provided.