Skip test when testing with installed package #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
ashmeenkaur,
a team,
gargnitingoogle and
BrennaEpp
and removed request for
a team and
gargnitingoogle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2928 +/- ##
==========================================
+ Coverage 75.62% 75.68% +0.05%
==========================================
Files 125 125
Lines 17641 17641
==========================================
+ Hits 13341 13351 +10
+ Misses 3738 3730 -8
+ Partials 562 560 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
reviewed
Jan 22, 2025
Yes, it's a temporary fix. Logged b/391754854 for a permanent fix. |
ashmeenkaur
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a temporary fix. We would like to get it working with installed package too but disabling it for now since metrics is currently not being worked upon.
Link to the issue in case of a bug fix.
b/391498868
Testing details