Handle write edge case when first write is out of order write #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by write at offset 0
ashmeenkaur
changed the title
ashmeenkaur
requested review from
meet2mky and
vadlakondaswetha
and removed request for
kislaykishore
internal/fs/inode/file.go
Outdated
| err := f.ensureBufferedWriteHandler(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| if f.bwh != nil { | ||
| return f.writeUsingBufferedWrites(ctx, data, offset) | ||
| if f.bwh != nil && !isTempFileInUse { |
There was a problem hiding this comment.
why do we need isTempFileInUse check here. Do you any scenario where bwh != nil but we need to use disk?
There was a problem hiding this comment.
Was not required, thanks! ensured that we never create bwh when temp file is in use (truncate was the other such scenario).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2929 +/- ##
==========================================
+ Coverage 75.66% 75.68% +0.02%
==========================================
Files 125 125
Lines 17641 17660 +19
==========================================
+ Hits 13348 13366 +18
Misses 3732 3732
- Partials 561 562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle write edge case when first write is out of order write followed by write at offset 0.
Issue: when we get out of order write, we flush buffered write handler (to finalize whatever we have) and also set bwh to nil
First out of order write creates a source object of size 0, so even after bwh is cleared, it is recreated during the write call. Later when a write at offset 0 happens, it will go to bwh. Partial writes to bwh and temp file can cause errors.
Solution: If temp file is in use, don't re-create buffered write handler.
Link to the internal issue
b/391545203
Testing details