Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing MinObject related issues in MRDWrapper #2936

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

abhishek10004
Copy link
Collaborator

  1. Ensure MRD's minObject is updated when inode's minObject is updated.

  2. Ensure that we set MRD to nil if there were any errors while creating it. (We observed that NewMultiRangeDownloader returned a non nil value for MRD even in case of error)

b/391534052

@abhishek10004 abhishek10004 added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.28%. Comparing base (8e0388a) to head (ecc5619).
Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
internal/fs/inode/file.go 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2936      +/-   ##
==========================================
- Coverage   75.66%   75.28%   -0.39%     
==========================================
  Files         125      125              
  Lines       17641    17695      +54     
==========================================
- Hits        13348    13321      -27     
- Misses       3732     3810      +78     
- Partials      561      564       +3     
Flag Coverage Δ
unittests 75.28% <82.14%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhishek10004 abhishek10004 marked this pull request as ready for review January 24, 2025 11:42
@abhishek10004 abhishek10004 requested a review from a team as a code owner January 24, 2025 11:42
@kislaykishore kislaykishore requested review from a team, tritone and gargnitingoogle and removed request for a team and tritone January 24, 2025 11:43
@abhishek10004 abhishek10004 added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests and removed execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR labels Jan 31, 2025
@abhishek10004 abhishek10004 merged commit d0c8162 into master Jan 31, 2025
12 checks passed
@abhishek10004 abhishek10004 deleted the abhishek/mrd_integration branch January 31, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants