-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing MinObject related issues in MRDWrapper #2936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek10004
added
execute-perf-test
Execute performance test in PR
execute-integration-tests
Run only integration tests
labels
Jan 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2936 +/- ##
==========================================
- Coverage 75.66% 75.28% -0.39%
==========================================
Files 125 125
Lines 17641 17695 +54
==========================================
- Hits 13348 13321 -27
- Misses 3732 3810 +78
- Partials 561 564 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested review from
a team,
tritone and
gargnitingoogle
and removed request for
a team and
tritone
January 24, 2025 11:43
vadlakondaswetha
previously approved these changes
Jan 31, 2025
abhishek10004
added
execute-perf-test
Execute performance test in PR
execute-integration-tests
Run only integration tests
and removed
execute-integration-tests
Run only integration tests
execute-perf-test
Execute performance test in PR
labels
Jan 31, 2025
vadlakondaswetha
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure MRD's minObject is updated when inode's minObject is updated.
Ensure that we set MRD to nil if there were any errors while creating it. (We observed that NewMultiRangeDownloader returned a non nil value for MRD even in case of error)
b/391534052