Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chunk retry timeout for buffered writes writer #2954

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ashmeenkaur
Copy link
Collaborator

Description

This is a temporary change to set no chunk retry timeout for buffered writes writer.

Link to the issue in case of a bug fix.

b/393112604

Testing details

  1. Manual - NA
  2. Unit tests - added
  3. Integration tests - NA

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.30%. Comparing base (e62b5a6) to head (9d05a6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2954      +/-   ##
==========================================
+ Coverage   75.28%   75.30%   +0.01%     
==========================================
  Files         125      125              
  Lines       17673    17674       +1     
==========================================
+ Hits        13306    13310       +4     
+ Misses       3805     3803       -2     
+ Partials      562      561       -1     
Flag Coverage Δ
unittests 75.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur marked this pull request as ready for review January 29, 2025 16:59
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner January 29, 2025 16:59
@kislaykishore kislaykishore requested a review from a team January 29, 2025 17:00
@ashmeenkaur ashmeenkaur merged commit 582233c into master Jan 30, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants