New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(testing): do not emit nil error formatting #3562

Draft

grayside wants to merge 3 commits into main from cloudrunci-retry-no-error

Contributor

grayside commented Nov 9, 2023 •

edited

Loading

Description

When using the cloudrunci retry mechanism, if multiple retries are made and the test fails without an error being reported, a nil error comes out. This was a distraction.

request: no acceptable response after 5 retries: %!w(<nil>))

This PR removes the nil error from output.

Checklist

I have followed Contributing Guidelines from CONTRIBUTING.MD
Tests pass: go test -v ./.. (see Testing)
Code formatted: gofmt (see Formatting)
Vetting pass: go vet (see Formatting)
These samples need a new API enabled in testing projects to pass (let us know which ones)
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
Please merge this PR for me once it is approved

grayside self-assigned this

product-auto-label bot added the samples label

subfuzion approved these changes

View reviewed changes

subfuzion marked this pull request as ready for review

August 28, 2024 15:09

subfuzion requested review from a team as code owners

August 28, 2024 15:10

subfuzion assigned subfuzion and unassigned grayside

subfuzion added the kokoro:force-run label

kokoro-team removed the kokoro:force-run label

subfuzion approved these changes

View reviewed changes

subfuzion requested a review from a team as a code owner

August 28, 2024 18:42

subfuzion added the kokoro:force-run label

subfuzion force-pushed the cloudrunci-retry-no-error branch from b9f3c8f to 6c49b69 Compare

August 28, 2024 19:25

kokoro-team removed the kokoro:force-run label

subfuzion force-pushed the cloudrunci-retry-no-error branch from 6c49b69 to ea728be Compare

August 28, 2024 20:29

subfuzion added the kokoro:force-run label

kokoro-team removed the kokoro:force-run label

subfuzion added the kokoro:force-run label

subfuzion force-pushed the cloudrunci-retry-no-error branch from f5b8ae0 to 67cd67a Compare

August 28, 2024 21:54

kokoro-team removed the kokoro:force-run label

subfuzion added the kokoro:force-run label

kokoro-team removed the kokoro:force-run label

subfuzion force-pushed the cloudrunci-retry-no-error branch from fcbfc2f to f95ff32 Compare

August 29, 2024 05:07


          chore(testing): do not emit nil error formatting

e6f0560

subfuzion force-pushed the cloudrunci-retry-no-error branch from f95ff32 to e6f0560 Compare

August 29, 2024 05:08


          chore(build): update go.mod

0ac03f3

subfuzion added the kokoro:force-run label

kokoro-team removed the kokoro:force-run label


          Merge branch 'main' into cloudrunci-retry-no-error

bb0e90b

subfuzion enabled auto-merge (squash)

August 29, 2024 16:25

subfuzion marked this pull request as draft

August 29, 2024 17:16

auto-merge was automatically disabled

August 29, 2024 17:16

Pull request was converted to draft

Member

subfuzion commented Aug 29, 2024

Converting back to draft on behalf of @grayside for now; will circle back to this later to investigate the test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples