Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(all): unskip 13 tests from issue #2811 #4247

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(all): unskip 13 tests from issue #2811 #4247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5facf36
fix(all): unskip 13 tests from issue #2811
Deleplace Jul 2, 2024
8b80723
Merge branch 'main' into issues/4246-unskip-tests
subfuzion Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion asset/quickstart/create-saved-query/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ func TestMain(m *testing.M) {
}

func TestCreateSavedQuery(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
buf := new(bytes.Buffer)
err := createSavedQuery(buf, projectID, savedQueryID)
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion asset/quickstart/delete-saved-query/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ func TestMain(m *testing.M) {
}

func TestDeleteSavedQuery(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
buf := new(bytes.Buffer)
err := deleteSavedQuery(buf, projectID, savedQueryID)
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion asset/quickstart/export-assets/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
)

func TestMain(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
tc := testutil.SystemTest(t)
env := map[string]string{"GOOGLE_CLOUD_PROJECT": tc.ProjectID}

Expand Down
1 change: 0 additions & 1 deletion asset/quickstart/get-saved-query/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ func TestMain(m *testing.M) {
}

func TestGetSavedQuery(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
buf := new(bytes.Buffer)
get_err := getSavedQuery(buf, projectID, savedQueryID)

Expand Down
1 change: 0 additions & 1 deletion asset/quickstart/list-saved-queries/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ func TestMain(m *testing.M) {
}

func TestListSavedQueries(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
buf := new(bytes.Buffer)
list_saved_queries_err := listSavedQueries(buf, projectID)

Expand Down
1 change: 0 additions & 1 deletion asset/quickstart/update-saved-query/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ func TestMain(m *testing.M) {
}

func TestUpdateSavedQuery(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
buf := new(bytes.Buffer)
newDescription := "This is a new description"
update_err := updateSavedQuery(buf, projectID, savedQueryID, newDescription)
Expand Down
1 change: 0 additions & 1 deletion bigquery/snippets/datatransfer/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
)

func TestDataTransfer(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
tc := testutil.SystemTest(t)
ctx := context.Background()

Expand Down
1 change: 0 additions & 1 deletion iam/deny/deny_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import (
)

func TestDenyPolicySnippets(t *testing.T) {
t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811")
tc := testutil.SystemTest(t)
ctx := context.Background()
var r *rand.Rand = rand.New(
Expand Down
Loading