Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudrun): delete old region tag "cloudrun_pubusub_dockerfile" #5126

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Feb 4, 2025

Description

Delete old region tag "cloudrun_pubsub_dockerfile" from run/pubsub/Dockerfile

Fixes
b/388068402

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 4, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by OremGLG, aims to clean up the run/pubsub/Dockerfile by removing an outdated region tag. Specifically:

  • Intent: To remove the obsolete cloudrun_pubsub_dockerfile tag from the Dockerfile. This is likely a cleanup task to improve consistency and reduce clutter.
  • Changes: The pull request modifies the run/pubsub/Dockerfile file. The changes involve deleting lines 16 and 52, removing the cloudrun_pubsub_dockerfile tag from both the beginning and end of the file. The before and after diffs show the removal of these lines clearly.
    • Lines 16 and 52 were removed. This is a simple deletion of comments, which is confirmed by the diff.
  • Associated Issue: The pull request references Google internal issue b/388068402, suggesting this is a fix for a reported problem.

I'll provide a more detailed review shortly, including a check of the test results and overall code quality.


A little poem for your coding pleasure:

A tag removed with care,
Clean code shines, a joyful flare,
Bugs flee in despair.

Thanks,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request deletes the old region tag cloudrun_pubsub_dockerfile from the run/pubsub/Dockerfile. This change aligns with best practices by removing redundant tags and improving maintainability. The commit message clearly describes the change and references the related issue. The description is thorough and the checklist items should be completed before merge.

@OremGLG OremGLG marked this pull request as ready for review February 4, 2025 20:28
@OremGLG OremGLG requested review from a team as code owners February 4, 2025 20:28
Copy link

snippet-bot bot commented Feb 4, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae
Copy link
Contributor

iennae commented Feb 4, 2025

still showing up in docs so not ready to be removed.

@eapl-gemugami eapl-gemugami marked this pull request as draft February 4, 2025 22:28
@eapl-gemugami eapl-gemugami added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2025
@OremGLG OremGLG added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2025
@OremGLG OremGLG marked this pull request as ready for review February 6, 2025 17:21
@OremGLG OremGLG merged commit 526e36c into GoogleCloudPlatform:main Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants