Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gae): migrate region tags from docs/appengine/datastore/indexes/index.yaml #5130

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Feb 5, 2025

Description

Migrate region tags from docs/appengine/datastore/indexes/index.yaml in order to align to pattern "product_regiontag_typeoffile_language"

Fixes
b/394594341
b/394594345

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 5, 2025
@OremGLG OremGLG marked this pull request as ready for review February 5, 2025 18:24
@OremGLG OremGLG requested review from a team as code owners February 5, 2025 18:24
Copy link

snippet-bot bot commented Feb 5, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion self-assigned this Feb 6, 2025
@telpirion telpirion merged commit d5dcc55 into GoogleCloudPlatform:main Feb 6, 2025
8 of 9 checks passed
@OremGLG OremGLG deleted the garciadiaz-chore-migrate-regions-indexes-yaml branch February 6, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants