-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename kubeflow/training-operator to kubeflow/trainer #2429
Rename kubeflow/training-operator to kubeflow/trainer #2429
Conversation
Hi @andreyvelich. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Electronic-Waste: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve cancel @cjwagner will take a look at this :) |
@@ -63,7 +63,7 @@ approve: | |||
- kubeflow/pipelines | |||
- kubeflow/spark-operator | |||
- kubeflow/testing | |||
- kubeflow/training-operator | |||
- kubeflow/trainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this changes hasn't happened yet, I'd recommend either waiting to /unhold
this until the switch has been made, or temporarily add this as an additional repo rather than immediately replacing it.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, cjwagner, Electronic-Waste The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We've renamed the repo, so we should be good to merge this PR. |
b3c0f15
into
GoogleCloudPlatform:master
@andreyvelich: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of: kubeflow/trainer#2402
These changes are required to rename
kubeflow/training-operator
tokubeflow/trainer
cc @kubeflow/kubeflow-steering-committee @franciscojavierarceo @juliusvonkohout @kubeflow/wg-training-leads @Electronic-Waste @astefanutti @airbornepony @chases2 @cjwagner @michelle192837 @nathanperkins
/hold for review