Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kubeflow/training-operator to kubeflow/trainer #2429

Merged

Conversation

andreyvelich
Copy link
Contributor

Part of: kubeflow/trainer#2402

These changes are required to rename kubeflow/training-operator to kubeflow/trainer

cc @kubeflow/kubeflow-steering-committee @franciscojavierarceo @juliusvonkohout @kubeflow/wg-training-leads @Electronic-Waste @astefanutti @airbornepony @chases2 @cjwagner @michelle192837 @nathanperkins

/hold for review

Copy link
Contributor

Hi @andreyvelich. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@Electronic-Waste: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nathanperkins
Copy link
Collaborator

/approve cancel

@cjwagner will take a look at this :)

@@ -63,7 +63,7 @@ approve:
- kubeflow/pipelines
- kubeflow/spark-operator
- kubeflow/testing
- kubeflow/training-operator
- kubeflow/trainer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this changes hasn't happened yet, I'd recommend either waiting to /unhold this until the switch has been made, or temporarily add this as an additional repo rather than immediately replacing it.

@cjwagner
Copy link
Member

cjwagner commented Feb 5, 2025

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, cjwagner, Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Contributor Author

We've renamed the repo, so we should be good to merge this PR.
https://github.com/kubeflow/trainer
/hold cancel

@google-oss-prow google-oss-prow bot merged commit b3c0f15 into GoogleCloudPlatform:master Feb 11, 2025
5 checks passed
Copy link
Contributor

@andreyvelich: Updated the plugins configmap in namespace default at cluster default using the following files:

  • key plugins.yaml using file prow/oss/plugins.yaml

In response to this:

Part of: kubeflow/trainer#2402

These changes are required to rename kubeflow/training-operator to kubeflow/trainer

cc @kubeflow/kubeflow-steering-committee @franciscojavierarceo @juliusvonkohout @kubeflow/wg-training-leads @Electronic-Waste @astefanutti @airbornepony @chases2 @cjwagner @michelle192837 @nathanperkins

/hold for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich andreyvelich deleted the trainer-github-repo branch February 11, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants