Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

materialDesign attribute for Material Design Charts #39

Closed
wants to merge 5 commits into from
Closed

materialDesign attribute for Material Design Charts #39

wants to merge 5 commits into from

Conversation

SmokyBob
Copy link
Contributor

#30 implementation for the charts that have a Material Design Beta version

ebidel
ebidel reviewed Mar 24, 2015
View reviewed changes
google-chart.html
* Try to use the Material Design version of the chart.
*
* Material Design Charts are avaliable in BETA for the following types:
* <ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use markdown in the docstring.

@ebidel
Copy link
Contributor

ebidel commented Mar 24, 2015

Reviewed

@SmokyBob
Copy link
Contributor Author

added commits for the fixes.
Not 100% sure about the doc string.
I've used markdown for the list, but not for the links for consistency with the links in the docstring, but I've noticed that other google web components are like google-youtube-upload and google-sheets use markdown for the link too.

Is markdown for the link the preferred way to express them in the docstring?

ebidel
ebidel reviewed Sep 24, 2015
View reviewed changes
demo.html
options='{"title": "Days in a month"}'
cols='[{"label": "Month", "type": "string"},{"label": "Days", "type": "number"}]'
rows='[["Jan", 31],["Feb", 28],["Mar", 31],["Apr", 30],["May", 31],["Jun", 30]]'
materialDesign>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

material-design

@ebidel
Copy link
Contributor

ebidel commented Sep 24, 2015

This PR is pre 1.0. Can you update it? Otherwise, we'll close.

@SmokyBob
Copy link
Contributor Author

Sorry not going to be able to update the PR for at least a couple weeks.

Feel free to close the PR, maybe I'll re implement the Issue later on the latest version

@ebidel ebidel closed this Sep 25, 2015
@albertolobrano albertolobrano mentioned this pull request Nov 6, 2015
Closed
@zmoshansky zmoshansky mentioned this pull request Dec 30, 2015
Closed
@alanent
Copy link

alanent commented Jul 3, 2018

Someone can help me for the integration in angular ? https://stackoverflow.com/q/51153920/9962015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SmokyBob @ebidel @alanent