-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map bounds to available data. #397
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
I added the option to disable fullscreen control. |
…howing back a map. Marker events where being set prior proper marker initialization. This ensures the marker is initialized is the map is set.
Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again. |
can't help thinking the Elm stuff should go in a seperate PR with a full explanation of why it was necessary and the consequences for non-Em users. But beyond that I really hope someone gets round to reviewing this as this is an important feaure |
The issue here is not related to Elm. Elm only made it surface. The situation is that markers can be added an removed to the DOM. The HTML DOM allows that and webcomponents honor that. The fix here is to check for the existence of the |
I am integrating google-map with an elm project and at a certain point I needed to have the map bounds available without callbacks.