Inject Multi-Release attr if any dependency contains it
#1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginTest.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
Goooler
commented
Feb 7, 2025
| @@ -324,4 +325,16 @@ public abstract class ShadowJar : | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private fun findAndAppendMultiReleaseAttr() { | |||
| val includeMultiReleaseAttr = includedDependencies.files.filter { it.extension == "jar" } | |||
There was a problem hiding this comment.
But I don't see any easy way to find dependencies added in from.
Goooler
force-pushed
the
g/20250207/multi-release-attr
branch
2 times, most recently
from
05e6bb5 to
d248ad1
Compare
Goooler
force-pushed
the
g/20250207/multi-release-attr
branch
2 times, most recently
from
ddd89b0 to
26056fd
Compare
Goooler
force-pushed
the
g/20250207/multi-release-attr
branch
from
26056fd to
66e849c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #449.