Feat/extract meta data from sale receipt #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var traderCodeCheckbox = document.getElementById('trader_code_not_available_checkbox_' + resourcePk); | ||
|
|
||
| if (!/^\d{10}$/.test(ownerMobileNumberInput.value) && !ownerMobileNumberCheckbox.checked && !ownerMobileNumberInput.disabled) { | ||
| alert('please enter valid number'); |
There was a problem hiding this comment.
Suggested change
| alert('please enter valid number'); | |
| alert('Please enter a valid mobile number.'); |
| } | ||
|
|
||
| if (!/^\d+$/.test(traderCodeInput.value) && !traderCodeCheckbox.checked && !traderCodeInput.disabled) { | ||
| alert('please enter valid trader code'); |
There was a problem hiding this comment.
Suggested change
| alert('please enter valid trader code'); | |
| alert('Please enter a valid trader code.'); |
admin/views.py
Outdated
| @@ -1222,6 +1236,14 @@ def update_receipt_status(): | |||
| return response | |||
|
|
|||
|
|
|||
| @admin.route("/update_receipt_data", methods=["POST"]) | |||
There was a problem hiding this comment.
please use hyphens in the routes.
| } | ||
|
|
||
|
|
||
| function handleTraderCodeInput(traderCode, resourcePk) { |
There was a problem hiding this comment.
Suggested change
| function handleTraderCodeInput(traderCode, resourcePk) { | |
| function handleTraderCodeInput(traderCode, resourcePk) { |
| .then(response => response.json()) | ||
| .then(data => { | ||
| if (data.success) { | ||
| if (data.message === "please provide receipt owner mobile number") { |
There was a problem hiding this comment.
this doesn't seem like a very reliable way to check for validation. Any small change to this big message will lead to a failure. I would suggest you either use data.success or send another parameter that is short and slugified.
| {% endfor %} | ||
| ]; | ||
|
|
||
| function toggleMobileNumberInput(checked, resourcePk) { |
There was a problem hiding this comment.
toggle is not a correct representation of the action. Toggle is for checkbox on/off toggle. This should be named like:
Suggested change
| function toggleMobileNumberInput(checked, resourcePk) { | |
| function onChangeMobileNumberInput(checked, resourcePk) { |
| } | ||
| } | ||
|
|
||
| function toggleTraderCodeInput(checked, resourcePk) { |
There was a problem hiding this comment.
Suggested change
| function toggleTraderCodeInput(checked, resourcePk) { | |
| function onChangeTraderCodeInput(checked, resourcePk) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gramhal.monday.com/boards/4834273983/pulses/6417088008