Added capability of customising minimum amplitude level of enclosures added internally by GrandOrgue https://github.com/GrandOrgue/grandorgue/issues/782 #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleg68 On Ubuntu 20.04 the build of this PR will crash immediately when I try to open the Audio/Midi->Organ Settings dialog. It doesn't matter what sample set I try to use or what settings I might have changed, GO reliably crashes as soon as I open the Organ Settings dialog. |
Fixed help window appearence Updated help Fixed buttons on the Settings dialog Fixed compilation errors Fixed "Apply or discard first" Fixed pre-commit Intermediate commit Intermediate commit
… added internally by GrandOrgue GrandOrgue#782
… added internally by GrandOrgue GrandOrgue#782
oleg68
force-pushed
the
feature/organ-settings-enclosures2
branch
from
b3b92ff to
a4dad85
Compare
|
@larspalo I fixed the crash |
|
@larspalo @rousseldenis could you approve this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Resolves: #782
This PR adds an Enclosures tab to the Organ Settings dialog.
It shows the Minimal amplitude level of all enclosures and allows the user to change them for all internal enclosures.