-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for PDF outlines #437
Open
inthewaves
wants to merge
11
commits into
GrapheneOS:main
Choose a base branch
from
inthewaves:pdfoutline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@inthewaves Needs to be rebased. |
I wrote a lot of the JS code years ago with testing help from an anonymous contributor. We also discussed some UI parts, but planning to rewrite the UI from scratch.
Fragments also let us have easier scroll-state preservation.
inthewaves
force-pushed
the
pdfoutline
branch
from
January 14, 2025 07:02
f535c72
to
8483f8d
Compare
@thestinger Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
PDFs have an ability to hold an outline and pdfjs supports it (see 8.2.2 Document Outline of the PDF 1.7 spec).
The outlines are lazily loaded; they won't be parsed if the user doesn't open the outlines screen. The outlines are first parsed in JavaScript first to resolve page numbers, then a simplified tree is encoded into JSON and passed to JVM code. Finally, the tree is reconstructed and displayed in the UI. Outline parsing is cancellable just in case.
No outlines
outlinestest-1.mp4
Big outline tree
https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/pdfreference1.7old.pdf
outlinestest-2.mp4