feat(utilities): split out visually hidden and document utility functionality #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azuryte5 Let me know what you think of the display/visually-hidden documentation. If you think it's good (or at least a good start) I'll do it to all utilities. |
|
@NickDJM Yes, I agree with the refactor and making it it's own section. |
|
@jlbdash Can you also review this. Does the documentation make sense? |
|
I'll work on add similar documentation to all utility classes in this PR and then it'll be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.visually-hiddenshould be it's own thing instead of lumping it into display and also utilities need to be documented.