Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new field option for full width, New filter for table markup and… #2147

Conversation

omarkasem
Copy link
Collaborator

@omarkasem omarkasem commented Sep 19, 2024

💾 Build file (ac57a03).

@Mwalek
Copy link

Mwalek commented Sep 25, 2024

@zackkatz @omarkasem the field is working (see image below):

Screenshot 2024-09-25 at 1 45 18 PM

However, I expected the 'Show Label' checkbox to be hidden, which is not the case (see image below).

Screenshot 2024-09-25 at 1 55 32 PM

@mrcasual
Copy link
Collaborator

mrcasual commented Sep 26, 2024

@omarkasem, please hide the "Show Label" checkbox when "Full Width" is checked, but leave the Admin Label.

@omarkasem
Copy link
Collaborator Author

Thanks @Mwalek for testing.
It's fixed now with the latest commit @mrcasual

/**
* Modify the markup for a table row.
* Modifies the table row markup for an entry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omarkasem, please take note of how we document filters. Also check the other changes in this and 5f9589e commits.

@mrcasual mrcasual merged commit a195e4a into develop Oct 1, 2024
1 check passed
@mrcasual mrcasual deleted the issue/684-add-full-width-field-setting-for-custom-content-fields-in-single-entry-table-layouts branch October 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Full width" field setting for Custom Content fields in single entry Table layouts
3 participants