Handle missing index/message on permalink page properly. (6.1)
#21706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle missing index/message on permalink page properly. * Adjusting function return value. * Improving test by mocking backend stub. * Adding test case. * Adding changelog snippet. * Making returned props optional for backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #21663 to
6.1.Description
Motivation and Context
Prior to this PR, the message permalink page was just showing a spinner when the referenced index was missing. This PR is fixing this by catching 404s and show a helpful message explaining the most probable cause.
Fixes #21653.
How Has This Been Tested?
Screenshots (if appropriate):
Before:
After:
Types of changes
Checklist: