Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: in impls and ompls update shell.yml files #387

Merged
merged 7 commits into from
Jan 15, 2024
Merged

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • made changes in shell.yml files in impls and ompls test folders

- timestamp: "2023-11-02T10:35:31.820Z"
duration: 3600
command: python3 /usr/local/bin/sampler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command should be provided in the model config above, rather than in an individual input
e.g.

child:
  pipeline:
    - sampler
  config:
    sampler:
      command: python3 /usr/local/bin/sampler
  inputs:
    - timestep: "2023-11-02T10:35:31:820Z"
      energy: 1
      duration: 10

p.s. your version will run correctly in this case where there is only one timestep, but if there are multiple timesteps it will break unless you manually copy the command into each one. Putting it in the config means the value its autromaticaly copied to every input.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this PR doesn't have any sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, as long as executable is renamed to command that was the only required change to the impls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment about the position of command

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some more small changes that I noticed, otherwise sgtm

@jmcook1186 jmcook1186 merged commit c380f62 into dev Jan 15, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the shell-update branch January 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants