-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: in impls and ompls update shell.yml files #387
Conversation
examples/impls/test/shell.yml
Outdated
- timestamp: "2023-11-02T10:35:31.820Z" | ||
duration: 3600 | ||
command: python3 /usr/local/bin/sampler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
command
should be provided in the model config above, rather than in an individual input
e.g.
child:
pipeline:
- sampler
config:
sampler:
command: python3 /usr/local/bin/sampler
inputs:
- timestep: "2023-11-02T10:35:31:820Z"
energy: 1
duration: 10
p.s. your version will run correctly in this case where there is only one timestep, but if there are multiple timesteps it will break unless you manually copy the command into each one. Putting it in the config means the value its autromaticaly copied to every input
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this PR doesn't have any sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, as long as executable
is renamed to command
that was the only required change to the impls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment about the position of command
Signed-off-by: Joseph Cook <[email protected]>
Signed-off-by: Joseph Cook <[email protected]>
Signed-off-by: Joseph Cook <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some more small changes that I noticed, otherwise sgtm
Types of changes
A description of the changes proposed in the Pull Request