Item Material Information Refactor

[YoungOnionMC]

What

Overhauls and breaks apart the various methods of ChemicalHelper into material related functions and the new ItemMaterialInfo methods, also renames UnificationEntry to the more suitable MaterialEntry.
Removes most of MaterialInfoLoader in favor of the more procedural method of generating item material stacks as mentioned in GTRecipeBuilder

Additional Information

GTRecipeBuilders now temporarily store all MaterialStack information for use in item decomposition information for recycling recipes if desired
Item decomposition material information also no longer depends on recipe order for material computation (ex needing to register iron plate decomp before iron furnace decomp)
GTRecipeBuilder allows for fluid inputs using a Material and amount instead of just the FluidStack if desired

Potential Incompatibilities

KubeJS recipes should be fine out of the box, just need to use the addMaterialInfo helper method if they want added decomp

[stanieldev]

I see no true issues for final commit, but I would definitely like some if statement blocks to be unwrapped and inverted for clarity for statement guarding.

I'll eventually get around to writing more JavaDocs when I don't think I'm gonna fail getting my degree because of capstone 😭

[screret]

its fine ig
wait for someone to do a thorough review though, I just read changes from last review

[omergunr100]

logic looks good but run spotlessApply

[omergunr100]

wrong pr

dn

[omergunr100]

you missed a unification entry so the build is failing.

we also need to try and replace those concurrent collections in ItemMaterialData with fast ones and see if it breaks.

[krossgg]

I want to look over all the streams too - there's a lot of long/nested ones that could probably be simplified. Will do it whenever I get on my pc.

Can you do more extensive testing with and without kube and make sure we didn't need those concurrent maps?

[omergunr100]

I can't mark the line in this review since the file hasn't been changed, but look at MaterialStack.isEmpty() it checks if the material is air, air is a valid material it should be GTMaterials.NULL imo.

Also consider adding an empty material stack to MaterialStack:

public static final MaterialStack EMPTY = new MaterialStack(GTMaterials.NULL, 0);

that way we could make all the material stack helper methods @NotNull and replace all the materialStack.material() == GTMaterial.Null checks with materialStack.isEmpty() which makes more sense and is easier to work with imo.