Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DATABASE] Geoloc enrichment #271
base: develop
Are you sure you want to change the base?
[DATABASE] Geoloc enrichment #271
Changes from all commits
9d82657
1261cbc
7adfad2
f55a956
b34fe0e
8a57579
ac34424
511c6ef
67a1b35
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code dupliqué : Il y a exactement le meme code lignes 92 à 106
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cela semble un des problèmes d’être passé par les API plutôt que directement par le connecteur de BDD. Ici on se retrouve a utiliser une nouvelle route updateOneAdministrative d'update qui n'est pas protégé (n'importe qui peut update une cavité ! SI vous voulez continuer à utiliser l'API plutot que la BDD directement il faudrait ajouter une protection minimaliste sur la route updateOneAdministrative pour éviter qu'elle puisse etre utiliser par n'importe qui. Par exemple en la limitant à un appel depuis la meme IP ? ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ce findAllEntries est un peu trop brutal et pas scalable. Que va t'il se passer si nous avions 200000 cavités ? Nous aurions en memoire un tableau de 200000 entrées à traiter ? Il faudrait plutot fonctionner par batch avec des LIMIT SQL. Je récupère de 0 à 1000 cavités puis de 1001 à 2000, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il faudrait attendre le résultat de cette update pour savoir si il s'est bien passé ou pas necessaire ?
Large diffs are not rendered by default.