[#350] attempting windows code signing

HASEL-UZH · Jan 24, 2025 · c44d490 · c44d490
1 parent 9c4e3be
commit c44d490
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,4 +1,4 @@
-name: Build
+name: Build and Publish PersonalAnalytics
 on:
   push:
     branches:
@@ -49,5 +49,12 @@ jobs:
           APPLE_ID: ${{ secrets.APPLE_ID }}
           APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
           APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
+          AZURE_PUBLISHER_NAME: ${{ vars.AZURE_PUBLISHER_NAME }}
+          AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
+          AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
+          AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
+          AZURE_ENDPOINT: ${{ secrets.AZURE_ENDPOINT }}
+          AZURE_CODE_SIGNING_NAME: ${{ secrets.AZURE_CODE_SIGNING_NAME }}
+          AZURE_CERT_PROFILE_NAME: ${{ secrets.AZURE_CERT_PROFILE_NAME }}
           CSC_LINK: ${{ secrets.CSC_LINK }}
           CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
diff --git a/src/electron/electron-builder.config.cjs b/src/electron/electron-builder.config.cjs
@@ -41,11 +41,18 @@ module.exports = {
     writeUpdateInfo: false
   },
   win: {
-    artifactName: '${productName}-${version}-Windows.${ext}'
+    target: ["nsis"],
+    azureSignOptions: {
+      publisherName: process.env.AZURE_PUBLISHER_NAME,
+      endpoint: process.env.AZURE_ENDPOINT,
+      codeSigningAccountName: process.env.AZURE_CODE_SIGNING_NAME,
+      certificateProfileName: process.env.AZURE_CERT_PROFILE_NAME,
+    },
   },
   nsis: {
     oneClick: true,
     deleteAppDataOnUninstall: false,
-    differentialPackage: false
+    differentialPackage: false,
+    artifactName: '${productName}-${version}-Windows.${ext}',
   }
 };