Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial gem files #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Initial gem files #1

wants to merge 1 commit into from

Conversation

kostyanf14
Copy link
Collaborator

No description provided.

@kostyanf14 kostyanf14 force-pushed the initial-release branch 3 times, most recently from 6cadf8e to 2ec5630 Compare February 22, 2023 13:26
@kostyanf14 kostyanf14 changed the title wip Initial gem files Feb 22, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@akihikodaki
Copy link

I don't think this is worth extracting into a distinct gem. This includes some hardcoded file names, and expects very specific assumptions like diffs are written in file, not generic IO. It is possible to convert it to more generic implementation, but only small portion of the code will remain after such conversion. Therefore, this gem is not likely to be useful outside of AutoHCK.

On the other hand, there is certainly some overhead of creating a gem. The number of the lines of the actual content in example, lib, and spec is 294, but the whole gem takes even 646 lines, which is more than twice. We will also need to update this gem in two steps: first in this repository, and later in AutoHCK to update gem version and make corresponding changes. We also need to duplicate our efforts to respond to dependabot, etc.

@kostyanf14
Copy link
Collaborator Author

@akihikodaki, We move this logic to a separate gem because we need it to run directly in Jenkins independently from AutoHCK.

Currently, we move it as is but we can extend the gem if found some new functionality for it.

@akihikodaki
Copy link

@kostyanf14 In that case we can simply add a new file which calls this logic to bin in AutoHCK repository. That will save the overhead I mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants