-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial gem files #1
base: main
Are you sure you want to change the base?
Conversation
6cadf8e
to
2ec5630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
2ec5630
to
46155bc
Compare
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
46155bc
to
dfe3357
Compare
I don't think this is worth extracting into a distinct gem. This includes some hardcoded file names, and expects very specific assumptions like diffs are written in file, not generic On the other hand, there is certainly some overhead of creating a gem. The number of the lines of the actual content in |
@akihikodaki, We move this logic to a separate gem because we need it to run directly in Jenkins independently from AutoHCK. Currently, we move it as is but we can extend the gem if found some new functionality for it. |
@kostyanf14 In that case we can simply add a new file which calls this logic to |
No description provided.