Fix parsing of Keycloak-related client configuration options #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two issues.
Issue 1: Keycloak Configuration Parsing
The pull request enables parsing of the client configuration when Keycloak-related options are present. Specifically, it now supports the following options:
hs_keycloak_client_id
hs_keycloak_realm
hs_keycloak_uri
Previously, client commands would fail with a confusing error message like the following:
Issue 2: Correcting ValueError Parameter
The second issue is related to the
ValueError
exception above, which was using the incorrect parameter. Thename
variable was mistakenly used, leading to confusion, as it was actually a list of known options generated earlier in the code (see this line, where it gets last set toignore
, the last option indefault_cfg
). The pull request corrects this by using thek
variable, which holds the current option name being parsed (v
holds the value).If additional subkeys (e.g.,
flags
) need to be added to the newdefault_cfg
keys, please advise on where to find the necessary information.