Support link names up to 64Kb #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2023
|
Because sending URLs longer than ~2 Kb is unreliable, this will be handled through new API exposed in HDFGroup/hsds#296 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the URL for cURL requests to the heap to support longer URLs.
The specific new value of
URL_MAX_LENGTH,((64 * 1024) + 1024) + 2048is the maximum tested link length in the API tests (64 * 1024 + 1024) plus the maximum expected length of the rest of a URL (2048).Requires HSDS to support long URLs, which is implemented in HDFGroup/hsds#294. This is a draft PR until that gets into master.