Directly check if CVars are valid rather than using a boolean #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also now checks if the map is being revisited (like in a hub map) if that's the case, just init only the cvars
|
I nearly forgot about this one, sorry! I don't have any maps off-hand to test it with but now that it's pulled in I'll be able to test it inherently so we'll see if it breaks! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
cvarsAvailablein favour of just checking the CVars array directly.Also,
WorldLoadednow checks if a level is being reopened (in a hub map).note: i don't have a hub map to test the worldloaded change, so hopefully it works lol