Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scraper: Better injection of id into pages #4

Open
kcmcleod opened this issue Apr 24, 2019 · 3 comments
Open

Scraper: Better injection of id into pages #4

kcmcleod opened this issue Apr 24, 2019 · 3 comments
Labels
in progress

Comments

@kcmcleod
Copy link
Contributor

Scraper only injects @ id into json-ld makup, not rdfa etc.

Scraper only injects into the 1st schema block; thus if more than 1 we have lots of blank nodes. Eg, https://reactome.org/content/detail/R-HSA-449147
@kcmcleod kcmcleod mentioned this issue Apr 24, 2019
Closed
@kcmcleod
Copy link
Contributor Author

kcmcleod commented May 6, 2019

Don't think I need to inject into rdfa?
Now have test to skip injection if rdfa detected

@kcmcleod
Copy link
Contributor Author

kcmcleod commented Jun 6, 2019

If @ context has multiple entries, it is overwriten it in the HTML with the single schema.org context

@kcmcleod kcmcleod mentioned this issue Jun 7, 2019
Closed
@AlasdairGray
Copy link
Member

WOuld need to reinvestigate this to see if it is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlasdairGray @kcmcleod