-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RSS/Atom feeds #188
Conversation
@LukeMoll do you know the correct way to generate an absolute URL from flask? During development or when running dynamically you can use |
What feels wrong about Given the GitHub repository is hard-coded in filters.py, I'd be comfortable hard-coding the website URL. As per https://flask.palletsprojects.com/en/2.0.x/api/#flask.url_for, we can set the URL root with The note in the docs that
is concerning, as AIUI we'd always be generating in a request context. |
This is now ready for review with two open questions: Where should we keep the files? I've gone with Does all the information generated seem correct? It looks it to me and I've validated the generated RSS/Atom using the W3C validator (it is valid). I've used Apart from that normal review things apply. |
Thanks for working on this, I'll try to give it a good look over on Monday. One quick comment based on the discussion here is that the cannonical URL for the website is www.HackSoc.org, so the base URL should probably reflect that. nginx is configured to redirect anyway so it shouldn't matter too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor documentation suggestion, looks good to me, thank you! Have tested RSS and Atom in Akregator and behave as expected.
Implementation for RSS/Atom feeds for the website.
Fixes #159