Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to show notification of library sync error (fixes #3848) #3869

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

slideclimb
Copy link
Collaborator

Fix #3848

Summary of additions and changes

Attempts to not fail without notification when getting an unexpected response from a remote library.

How to test this pull request

I'm not sure how to trigger an error, but have verified that logging into Mendeley and syncing the library still works.

  • Updated the documentation, or no update necessary
  • Added tests, or no tests necessary

@slideclimb slideclimb self-assigned this Jan 28, 2025
@slideclimb slideclimb requested a review from PHPirates as a code owner January 28, 2025 20:10
Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could reproduce the exception a couple of times, but not reliably. The cause is an invalid token error, I think when there is no token present in the password safe. Added a try catch in the correct place to convert the exception into a notification

@slideclimb slideclimb merged commit be06007 into master Jan 29, 2025
10 checks passed
@slideclimb slideclimb deleted the 3848-library-crash branch January 29, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.ktor.http.parsing.ParseException: Expected delimiter , at position 24
2 participants