[Enhancement] Add Gibdo Trade Sequence Options

[zodiac-ill]

Add options to the Gibdo trade sequence beneath the well in Ikana.

• Vanilla: Gibdo trade sequence works normally
• MM3D: Gibdos will only require (and take) one of the item they request, as in MM3D. Additionally, the Gibdo that requests a blue potion will also accept a red potion.
• No Trade: Gibdos will not require or take any items. They will disappear without requiring a trade.

Build Artifacts

• 2ship-linux.zip
• 2ship-mac.zip
• 2ship-windows.zip

[garrettjoecox]

Solid job! Sorry it's taken a minute to get you some feedback.

So for the most part you nailed it with using GameInteractor_Should in places to branch into custom behavior, with the main exception that you should introduce that behavior outside of the original source.

So instead of

if (GameInteractor_Should(VB_..., true)) {
    // Original Stuff
} else {
    // Custom Stuff
}

In your file, where you set *should = false; is where the custom stuff should belong.

The other part is I'd like to not add new values to the EnTalkGibudRequestedItemIndex enum and sRequestedItemTable. Let me know if you run into trouble with this and I can try and figure something out.

[zodiac-ill]

When you get the chance, please review revised commit