-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgui 1.90.6 -> 1.91.6 #4838
Merged
Merged
imgui 1.90.6 -> 1.91.6 #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://github.com/ocornut/imgui/blob/0b8ff4b2382d4bbd5c168b1a5373f86ea3145957/imgui_widgets.cpp#L1121-L1139 we were using the removed `frame_padding` argument for `ImageButton`, we need to `PushStyleVar`/`PopStyleVar` now we also need to specify `str_id` as the first arg now
Closed
briaguya-ai
force-pushed
the
imgui-1916
branch
from
January 10, 2025 09:15
d0997e2
to
9fa5109
Compare
Archez
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is an opportunity to make a UIWidgets::ImageButton or some equivalent.
Considering the improvements being made over in 2ship, that can wait for when all the menu stuff is pulled over to here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs:
Build Artifacts