Skip to content

Commit

Permalink
FIX(a11y): Update accessible names and descriptions
Browse files Browse the repository at this point in the history
  • Loading branch information
@Hartmnt
Hartmnt committed Jan 4, 2024
1 parent 5110717 commit 8596a37
Show file tree
Hide file tree
Showing 19 changed files with 281 additions and 85 deletions.
33 changes: 24 additions & 9 deletions src/mumble/ACLEditor.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
<layout class="QVBoxLayout">
<item>
<widget class="QTabWidget" name="qtwTab">
<property name="accessibleName">
<string>Maximum Users</string>
</property>
<property name="currentIndex">
<number>1</number>
</property>
Expand Down Expand Up @@ -79,7 +82,7 @@
This value enables you to change the way Mumble arranges the channels in the tree. A channel with a higher &lt;i&gt;Position&lt;/i&gt; value will always be placed below one with a lower value and the other way around. If the &lt;i&gt;Position&lt;/i&gt; value of two channels is equal they will get sorted alphabetically by their name.</string>
</property>
<property name="accessibleName">
<string>Position</string>
<string>Channel position</string>
</property>
<property name="maximum">
<number>99</number>
Expand Down Expand Up @@ -112,7 +115,7 @@ This value enables you to change the way Mumble arranges the channels in the tre
This value allows you to set the maximum number of users allowed in the channel. If the value is above zero, only that number of users will be allowed to enter the channel. If the value is zero, the maximum number of users in the channel is given by the server's default limit.</string>
</property>
<property name="accessibleName">
<string>Maximum users</string>
<string>Channel maximum users</string>
</property>
</widget>
</item>
Expand All @@ -125,6 +128,9 @@ This value allows you to set the maximum number of users allowed in the channel.
<string>&lt;b&gt;Temporary&lt;/b&gt;&lt;br /&gt;
When checked the channel created will be marked as temporary. This means when the last player leaves it the channel will be automatically deleted by the server.</string>
</property>
<property name="accessibleName">
<string/>
</property>
<property name="text">
<string>Temporary</string>
</property>
Expand Down Expand Up @@ -176,7 +182,7 @@ When checked the channel created will be marked as temporary. This means when th
</sizepolicy>
</property>
<property name="accessibleName">
<string>Description</string>
<string>Channel description</string>
</property>
</widget>
</item>
Expand Down Expand Up @@ -376,7 +382,7 @@ This list contains all members that were added to the group by the current chann
<string>Type in the name of a user you wish to add to the group and click Add.</string>
</property>
<property name="accessibleName">
<string>Add members to group</string>
<string>Select member to add</string>
</property>
<property name="editable">
<bool>true</bool>
Expand Down Expand Up @@ -441,7 +447,7 @@ This list contains all members that were added to the group by the current chann
Contains a list of members whose group membership will not be inherited from the parent channel.</string>
</property>
<property name="accessibleName">
<string>Foreign group members</string>
<string>Excluded group members</string>
</property>
</widget>
</item>
Expand All @@ -460,7 +466,7 @@ Contains a list of members whose group membership will not be inherited from the
<string>Type in the name of a user you wish to remove from the group and click Add.</string>
</property>
<property name="accessibleName">
<string>Remove member from group</string>
<string>Select member to remove</string>
</property>
<property name="editable">
<bool>true</bool>
Expand Down Expand Up @@ -570,7 +576,7 @@ Contains the list of members inherited by the current channel. Uncheck &lt;i&gt;
<item row="0" column="0" rowspan="2" colspan="5">
<widget class="QListWidget" name="qlwACLs">
<property name="toolTip">
<string>List of entries</string>
<string>List of ACL entries</string>
</property>
<property name="whatsThis">
<string>This shows all the entries active on this channel. Entries inherited from parent channels will be shown in italics.&lt;br /&gt;ACLs are evaluated top to bottom, meaning priority increases as you move down the list.</string>
Expand Down Expand Up @@ -738,7 +744,10 @@ Contains the list of members inherited by the current channel. Uncheck &lt;i&gt;
<string>This controls which group of users this entry applies to.&lt;br /&gt;Note that the group is evaluated in the context of the channel the entry is used in. For example, the default ACL on the Root channel gives &lt;i&gt;Write&lt;/i&gt; permission to the &lt;i&gt;admin&lt;/i&gt; group. This entry, if inherited by a channel, will give a user write privileges if he belongs to the &lt;i&gt;admin&lt;/i&gt; group in that channel, even if he doesn't belong to the &lt;i&gt;admin&lt;/i&gt; group in the channel where the ACL originated.&lt;br /&gt;If a group name starts with '!', its membership is negated, and if it starts with '~', it is evaluated in the channel the ACL was defined in, rather than the channel the ACL is active in.&lt;br /&gt;If a group name starts with '#', it is interpreted as an access token. Users must have entered whatever follows the '#' in their list of access tokens to match. This can be used for very simple password access to channels for non-authenticated users.&lt;br /&gt;If a group name starts with '$', it will only match users whose certificate hash matches what follows the '$'.&lt;br /&gt;A few special predefined groups are:&lt;br /&gt;&lt;b&gt;all&lt;/b&gt; - Everyone will match.&lt;br /&gt;&lt;b&gt;auth&lt;/b&gt; - All authenticated users will match.&lt;br /&gt;&lt;b&gt;sub,a,b,c&lt;/b&gt; - User currently in a sub-channel minimum &lt;i&gt;a&lt;/i&gt; common parents, and between &lt;i&gt;b&lt;/i&gt; and &lt;i&gt;c&lt;/i&gt; channels down the chain. See the website for more extensive documentation on this one.&lt;br /&gt;&lt;b&gt;in&lt;/b&gt; - Users currently in the channel will match (convenience for '&lt;i&gt;sub,0,0,0&lt;/i&gt;').&lt;br /&gt;&lt;b&gt;out&lt;/b&gt; - Users outside the channel will match (convenience for '&lt;i&gt;!sub,0,0,0&lt;/i&gt;').&lt;br /&gt;Note that an entry applies to either a user or a group, not both.</string>
</property>
<property name="accessibleName">
<string>Group this entry applies to</string>
<string>Select group</string>
</property>
<property name="accessibleDescription">
<string>Selects a group this ACL entry applies to. Selecting a group and selecting a user are mutually exclusive.</string>
</property>
<property name="editable">
<bool>true</bool>
Expand Down Expand Up @@ -770,7 +779,10 @@ Contains the list of members inherited by the current channel. Uncheck &lt;i&gt;
<string>This controls which user this entry applies to. Just type in the user name and hit enter to query the server for a match.</string>
</property>
<property name="accessibleName">
<string>User this entry applies to</string>
<string>Select user</string>
</property>
<property name="accessibleDescription">
<string>Selects a user this ACL entry applies to. Selecting a group and selecting a user are mutually exclusive.</string>
</property>
<property name="editable">
<bool>true</bool>
Expand All @@ -787,6 +799,9 @@ Contains the list of members inherited by the current channel. Uncheck &lt;i&gt;
</item>
<item>
<widget class="QGroupBox" name="qgbACLpermissions">
<property name="accessibleName">
<string>List of available permissions</string>
</property>
<property name="title">
<string>Permissions</string>
</property>
Expand Down
17 changes: 16 additions & 1 deletion src/mumble/ASIOInput.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<string>This chooses what device to query. You still need to actually query the device and select which channels to use.</string>
</property>
<property name="accessibleName">
<string>Device to use for microphone</string>
<string>Device list</string>
</property>
</widget>
</item>
Expand Down Expand Up @@ -214,6 +214,9 @@
<height>16777215</height>
</size>
</property>
<property name="accessibleName">
<string>Move from unused to microphone list</string>
</property>
<property name="text">
<string>&lt;-</string>
</property>
Expand All @@ -227,6 +230,9 @@
<height>16777215</height>
</size>
</property>
<property name="accessibleName">
<string>Move from microphone to unused list</string>
</property>
<property name="text">
<string>-&gt;</string>
</property>
Expand Down Expand Up @@ -273,6 +279,9 @@
<height>16777215</height>
</size>
</property>
<property name="accessibleName">
<string>List of unused devices</string>
</property>
</widget>
</item>
</layout>
Expand Down Expand Up @@ -300,6 +309,9 @@
<height>16777215</height>
</size>
</property>
<property name="accessibleName">
<string>Move from unused to speakers list</string>
</property>
<property name="text">
<string>-&gt;</string>
</property>
Expand All @@ -313,6 +325,9 @@
<height>16777215</height>
</size>
</property>
<property name="accessibleName">
<string>Move from speakers to unused list</string>
</property>
<property name="text">
<string>&lt;-</string>
</property>
Expand Down
68 changes: 52 additions & 16 deletions src/mumble/AudioInput.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@
</sizepolicy>
</property>
<property name="toolTip">
<string>Input method for audio</string>
<string>Input backend for audio</string>
</property>
<property name="whatsThis">
<string>&lt;b&gt;This is the input method to use for audio.&lt;/b&gt;</string>
</property>
<property name="accessibleName">
<string>Audio system</string>
<string>Audio input system</string>
</property>
</widget>
</item>
Expand Down Expand Up @@ -74,7 +74,7 @@
<string>&lt;b&gt;This is the input device to use for audio.&lt;/b&gt;</string>
</property>
<property name="accessibleName">
<string>Input device</string>
<string>Audio input device</string>
</property>
<property name="sizeAdjustPolicy">
<enum>QComboBox::AdjustToContents</enum>
Expand Down Expand Up @@ -244,7 +244,10 @@
<string>&lt;b&gt;DoublePush Time&lt;/b&gt;&lt;br /&gt;If you press the push-to-talk key twice during the configured interval of time it will be locked. Mumble will keep transmitting until you hit the key once more to unlock PTT again.</string>
</property>
<property name="accessibleName">
<string>PTT lock threshold</string>
<string>Push to talk lock threshold</string>
</property>
<property name="accessibleDescription">
<string>Switch between push to talk and continuous mode by double tapping in this time frame</string>
</property>
<property name="maximum">
<number>1000</number>
Expand Down Expand Up @@ -282,8 +285,14 @@
<property name="toolTip">
<string>Time the microphone stays open after the PTT key is released</string>
</property>
<property name="whatsThis">
<string>&lt;b&gt;Voice hold Time&lt;/b&gt;&lt;br /&gt;After you release the push-to-talk key Mumble will keep transmitting for the selected amount of time.</string>
</property>
<property name="accessibleName">
<string>PTT hold threshold</string>
<string>Push to talk hold threshold</string>
</property>
<property name="accessibleDescription">
<string>Extend push to talk send time after the key is released by this amount of time</string>
</property>
<property name="maximum">
<number>5000</number>
Expand Down Expand Up @@ -332,7 +341,7 @@
<string>&lt;b&gt;This selects how long after a perceived stop in speech transmission should continue.&lt;/b&gt;&lt;br /&gt;Set this higher if your voice breaks up when you speak (seen by a rapidly blinking voice icon next to your name).</string>
</property>
<property name="accessibleName">
<string>Silence below</string>
<string>Voice hold time</string>
</property>
<property name="minimum">
<number>20</number>
Expand Down Expand Up @@ -423,7 +432,10 @@
<string>&lt;b&gt;This sets the trigger values for voice detection.&lt;/b&gt;&lt;br /&gt;Use this together with the Audio Statistics window to manually tune the trigger values for detecting speech. Input values below &quot;Silence Below&quot; always count as silence. Values above &quot;Speech Above&quot; always count as voice. Values in between will count as voice if you're already talking, but will not trigger a new detection.</string>
</property>
<property name="accessibleName">
<string>Silence below</string>
<string>Silence below threshold</string>
</property>
<property name="accessibleDescription">
<string>This sets the threshold when Mumble will consider a signal definitively silence</string>
</property>
<property name="minimum">
<number>1</number>
Expand Down Expand Up @@ -451,7 +463,10 @@
<string>&lt;b&gt;This sets the trigger values for voice detection.&lt;/b&gt;&lt;br /&gt;Use this together with the Audio Statistics window to manually tune the trigger values for detecting speech. Input values below &quot;Silence Below&quot; always count as silence. Values above &quot;Speech Above&quot; always count as voice. Values in between will count as voice if you're already talking, but will not trigger a new detection.</string>
</property>
<property name="accessibleName">
<string>Speech above</string>
<string>Speech above threshold</string>
</property>
<property name="accessibleDescription">
<string>This sets the threshold when Mumble will consider a signal definitively speech</string>
</property>
<property name="minimum">
<number>1</number>
Expand Down Expand Up @@ -503,7 +518,10 @@
<string>&lt;b&gt;This selects how many audio frames should be put in one packet.&lt;/b&gt;&lt;br /&gt;Increasing this will increase the latency of your voice, but will also reduce bandwidth requirements.</string>
</property>
<property name="accessibleName">
<string>Audio per packet in milliseconds</string>
<string>Audio per packet</string>
</property>
<property name="accessibleDescription">
<string>This sets how much speech is packed into a single package</string>
</property>
<property name="minimum">
<number>1</number>
Expand Down Expand Up @@ -554,7 +572,10 @@
<string>&lt;b&gt;This sets the quality of compression.&lt;/b&gt;&lt;br /&gt;This determines how much bandwidth Mumble is allowed to use for outgoing audio.</string>
</property>
<property name="accessibleName">
<string>Audio compression quality in kilobit per second</string>
<string>Audio compression quality</string>
</property>
<property name="accessibleDescription">
<string>This sets the target compression bitrate</string>
</property>
<property name="minimum">
<number>8000</number>
Expand Down Expand Up @@ -640,6 +661,9 @@
<property name="accessibleName">
<string>Maximum amplification</string>
</property>
<property name="accessibleDescription">
<string>Speech is dynamically amplified by at most this amount</string>
</property>
<property name="maximum">
<number>19500</number>
</property>
Expand Down Expand Up @@ -707,7 +731,7 @@
<string>Don't use noise suppression.</string>
</property>
<property name="accessibleName">
<string>Noise suppression disabled</string>
<string/>
</property>
<property name="text">
<string>Disabled</string>
Expand Down Expand Up @@ -770,7 +794,10 @@
<string>&lt;b&gt;This sets the amount of noise suppression to apply.&lt;/b&gt;&lt;br /&gt;The higher this value, the more aggressively stationary noise will be suppressed.</string>
</property>
<property name="accessibleName">
<string>Noise suppression</string>
<string>Noise suppression strength</string>
</property>
<property name="accessibleDescription">
<string>This sets the noise suppression strength</string>
</property>
<property name="minimum">
<number>15</number>
Expand Down Expand Up @@ -840,8 +867,11 @@
<property name="toolTip">
<string>Gets played when stopping to transmit</string>
</property>
<property name="accessibleName">
<string>Path to audio file</string>
</property>
<property name="accessibleDescription">
<string>Path to audio cue file when stopping to speak</string>
<string>Path to audio cue file when stopping to speak. Use the browse button to open a file dialog.</string>
</property>
</widget>
</item>
Expand All @@ -850,7 +880,7 @@
<item>
<widget class="QSpinBox" name="qsbIdle">
<property name="accessibleName">
<string>Initiate idle action after (in minutes)</string>
<string>Idle action time threshold (in minutes)</string>
</property>
<property name="minimum">
<number>1</number>
Expand Down Expand Up @@ -921,8 +951,11 @@
<property name="toolTip">
<string>Gets played when you are trying to speak while being muted</string>
</property>
<property name="accessibleName">
<string>Path to audio file</string>
</property>
<property name="accessibleDescription">
<string>Path to mute cue file</string>
<string>Path to mute cue file. Use the browse button to open a file dialog.</string>
</property>
</widget>
</item>
Expand All @@ -941,8 +974,11 @@
<property name="toolTip">
<string>Gets played when starting to transmit</string>
</property>
<property name="accessibleName">
<string>Path to audio file</string>
</property>
<property name="accessibleDescription">
<string>Path to audio cue file when starting to speak</string>
<string>Path to audio cue file when starting to speak. Use the browse button to open a file dialog.</string>
</property>
</widget>
</item>
Expand Down
Loading

0 comments on commit 8596a37

Please sign in to comment.