FlxUICursor: prevent/remove references to disconnected gamepads #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
changed the title
|
I did some quick tests and no longer encountered any crashes. If any other problems crop up I'll let you know or make another PR. Thank you for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlxUICursor is oddly written, when there's no gamepads it adds gamepad listeners with a null gamepad, then checks for null gamepads every frame for dozens of inputs. this change will simply not add useless button listeners unless theres a connected gamepad. It also checks whether the current gamepad is disconnected, and removes listeners when that gamepad is disconnected, fixing HaxeFlixel/flixel#2991
@DigiEggz please try this out, or lmk if you don't have time