Modify FlxText to create a bitmap with an informative key. #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems relevant to: #3081 I'd like to determine whether this affects memory leaks resulting from FlxText bitmap keying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, I've had to look over the list of graphics in the BitmapFrontEnd cache to determine the cause of memory issues.
In this circumstance, having readable keys is important; for example, if one bit of text appears in the cache a lot, there may be something forcing it to re-render too often.
This PR changes auto-generated graphics created by FlxText to include the actual text in their key (
text123will instead betext(Hello World)123). This shouldn't have any negative impact but should improve debugging.