Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid max texture size values by caching it on create #3333

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix invalid max texture size values by caching it on create #3333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions flixel/FlxGame.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,12 @@ class FlxGame extends Sprite
addChild(postProcessLayer);
#end

// We have to call this after a stage is created
// otherwise it will fail and cause a crash
#if FLX_OPENGL_AVAILABLE
FlxG.bitmap.setMaxTextureSize();
#end

// Creating the debugger overlay
#if FLX_DEBUG
debugger = new FlxDebugger(FlxG.stage.stageWidth, FlxG.stage.stageHeight);
Expand Down
10 changes: 4 additions & 6 deletions flixel/system/frontEnds/BitmapFrontEnd.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class BitmapFrontEnd
*
* @see https://opengl.gpuinfo.org/displaycapability.php?name=GL_MAX_TEXTURE_SIZE
*/
public var maxTextureSize(get, never):Int;
public var maxTextureSize(default, null):Int;
#end

/**
Expand Down Expand Up @@ -393,12 +393,10 @@ class BitmapFrontEnd
}

#if FLX_OPENGL_AVAILABLE
function get_maxTextureSize():Int
@:allow(flixel.FlxGame)
function setMaxTextureSize():Void
{
if (FlxG.stage.window.context.attributes.hardware)
return cast GL.getParameter(GL.MAX_TEXTURE_SIZE);

return -1;
maxTextureSize = FlxG.stage.window.context.attributes.hardware ? cast GL.getParameter(GL.MAX_TEXTURE_SIZE) : -1;
}
#end

Expand Down
Loading